Added IE 187(Maximum Wait Time) and 188(Millisecond Time Stamp) to gtp_v2.py
Adds to the GTPv2 protocol capability of Scapy by adding support for the Information Elements 187(Maximum Wait Time) and 188(Millisecond Time Stamp).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 49.23%. Comparing base (
8cea357) to head (36ec027). Report is 37 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (8cea357) and HEAD (36ec027). Click for more details.
HEAD has 19 uploads less than BASE
| Flag | BASE (8cea357) | HEAD (36ec027) | |------|------|------| ||20|1|
Additional details and impacted files
@@ Coverage Diff @@
## master #4376 +/- ##
===========================================
- Coverage 82.21% 49.23% -32.99%
===========================================
Files 353 346 -7
Lines 83586 77806 -5780
===========================================
- Hits 68723 38304 -30419
- Misses 14863 39502 +24639
| Files | Coverage Δ | |
|---|---|---|
| scapy/contrib/gtp_v2.py | 91.44% <100.00%> (-3.98%) |
:arrow_down: |
Thanks for the PR ! Could you add a unit test that builds and/or dissects those new packets? Thanks
Thanks for the PR ! Could you add a unit test that builds and/or dissects those new packets? Thanks
Is there anywhere that shows how to build the test?
You can read the doc: https://scapy.readthedocs.io/en/latest/development.html#testing-with-utscapy
but the format is trivial to understand.
You can add them to: https://github.com/secdev/scapy/blob/master/test/contrib/gtp_v2.uts