scapy icon indicating copy to clipboard operation
scapy copied to clipboard

Launch Unit Tests on *BSD

Open guedou opened this issue 3 years ago • 4 comments

This PR is an attempt at automatically testing Scapy on *BSD. These unit tests will only be triggered when a PR is labelled with specific labels (i.e ci/bsd, ci/freebsd...)

guedou avatar Aug 16 '22 09:08 guedou

Codecov Report

Merging #3716 (1687b07) into master (5fa6428) will increase coverage by 0.05%. Report is 15 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3716      +/-   ##
==========================================
+ Coverage   49.60%   49.66%   +0.05%     
==========================================
  Files         341      342       +1     
  Lines       76081    76267     +186     
==========================================
+ Hits        37742    37880     +138     
- Misses      38339    38387      +48     

see 17 files with indirect coverage changes

codecov[bot] avatar Aug 16 '22 10:08 codecov[bot]

The test named Check offline sniff() with a PcapNg file and a filter (by file object) is failing on OpenBSD 7.1 with the following error scapy.error.Scapy_Exception: Failed to compile filter expression udp (-1). I will try to reproduce the issue on a local VM.

guedou avatar Aug 19 '22 10:08 guedou

@polybassa are there some tests that should be disabled https://github.com/secdev/scapy/runs/7918151585?check_suite_focus=true#step:3:2310 ?

guedou avatar Aug 19 '22 12:08 guedou

Certain tests run only on Linux and are skipped automatically. As a notification, this message is sent to stderr if skipped. In my opinion, they should not be disabled.

Viele Grüße

Nils Weiß

On August 19, 2022 2:50:05 PM GMT+02:00, Guillaume Valadon @.> wrote: @. are there some tests that should be disabled

https://github.com/secdev/scapy/runs/7918151585?check_suite_focus=true#step:3:2310 ?

-- Reply to this email directly or view it on GitHub: https://github.com/secdev/scapy/pull/3716#issuecomment-1220638572 You are receiving this because you were mentioned.

Message ID: @.***>

polybassa avatar Aug 19 '22 20:08 polybassa