add BGP LARGE_COMMUNITY Path Attribute

Open Qingtian-Zou opened this issue 4 years ago • 3 comments

add support for BGP protocol's LARGE_COMMUNITY Path Attribute, introduced with RFC 8092 and RFC 8195

Feb 20 '22 19:02 Qingtian-Zou

Codecov Report

Merging #3535 (e0b18c8) into master (4f42d25) will increase coverage by 35.31%. The diff coverage is 87.50%.

:exclamation: Current head e0b18c8 differs from pull request most recent head 85dcca5. Consider uploading reports for the commit 85dcca5 to get more accurate results

@@             Coverage Diff             @@
##           master    #3535       +/-   ##
===========================================
+ Coverage   51.01%   86.32%   +35.31%     
===========================================
  Files         170      282      +112     
  Lines       39343    64084    +24741     
===========================================
+ Hits        20069    55320    +35251     
+ Misses      19274     8764    -10510

Impacted Files	Coverage Δ
scapy/contrib/bgp.py	`92.06% <87.50%> (+43.99%)`	:arrow_up:
scapy/contrib/automotive/ecu.py	`94.33% <0.00%> (ø)`
scapy/layers/pflog.py	`94.73% <0.00%> (ø)`
scapy/contrib/automotive/uds_scan.py	`76.61% <0.00%> (ø)`
scapy/contrib/automotive/ccp.py	`97.05% <0.00%> (ø)`
scapy/contrib/automotive/obd/pid/pids_20_3F.py	`100.00% <0.00%> (ø)`
scapy/contrib/automotive/obd/mid/mids.py	`100.00% <0.00%> (ø)`
scapy/contrib/automotive/gm/gmlanutils.py	`86.95% <0.00%> (ø)`
scapy/layers/tls/crypto/hkdf.py	`100.00% <0.00%> (ø)`
scapy/contrib/automotive/doip.py	`57.95% <0.00%> (ø)`
... and 238 more

Feb 20 '22 19:02 codecov[bot]

Thanks a lot for the PR. Could you provide a unit test that dissects a real packet ? You can put it insid https://github.com/secdev/scapy/blob/master/test/contrib/bgp.uts

Feb 21 '22 11:02 gpotter2

Now the dissecting should be OK ... I think line 2079 to line 2095 in "bgp.py" might be implemented in another way, or it may introduce similar problems for future path attributes.

Feb 23 '22 02:02 Qingtian-Zou