httparse

httparse copied to clipboard

Just a very small tweak that I found by accident while skimming the code. By the way, if you wish I could apply Rust Format defaults to the project as...

reu

It would be nice to be able to access the error descriptions as `&'static str` via the now private `Error::description_str`, especially because `std::error::Error::description` is deprecated.

FlorianUekermann

double quotes in headers can not be parsed

3

In the [header name map](https://github.com/seanmonstar/httparse/blob/master/src/lib.rs#L96), index 34 is false. So when parsing headers, the program will return Error::HeaderName when meeting double quotes(ascii number is 34) . However, bouble quotes in...

clouduol

Parse from noncontiguous byte slices?

5

I am building a HTTP server on top of tokio that needs to perform minimal memory allocations per client TCP connection, regardless of how many HTTP requests are received through...

EkardNT

Support custom Version Parsers when protocol name is not HTTP

7

In order to parse HTTP based protocol (like RTSP) for example, it is required to know what is the name of the protocol. 1. This PR attempts very hard to...

tsnoam

Reduce Usage of Unsafe

3

Remove unnecessary usage of `unsafe` and replace some unsafe code with equivalent safe code. The safe implementation of `iter::Bytes::slice_skip` proposed by this pull request has been benchmarked to be (slightly)...

CalebLBaker

Benchmark is not an apples to apples comparison (sse4.2)

8

Hello, first, thanks for making this tool. I wanted to point out your benchmark is a bit unfair as you compare httparse sse4 against picohttpparser without sse4. The reason picohttpparser...

errantmind

If the HTTP message begins with whitespace, the resulting error is "invalid HTTP version". This felt misleading, or at least less helpful than it could be, since the version (HTTP/1.1)...

Chris-Barrett-FW

Private function shrink() is unsound

2

This code does not uphold Rust safety invariants: either `debug_assert!()` should be `assert!()` or the function must be marked `unsafe fn`: https://github.com/seanmonstar/httparse/blob/6f696f5d027f35e11a70181c839b574e20335a74/src/lib.rs#L38-L43 Also, it's weird to see a custom function...

Shnatsel

Document the AVX2 intructions

3

These were added in #40, but understanding exactly what is happening is difficult. It'd be best to document what in the world is happening :)

seanmonstar