SDV icon indicating copy to clipboard operation
SDV copied to clipboard
verified publisher icon sdv-dev

Investigate HMA case where parent is missing num_rows column

Open frances-h opened this issue 2 years ago • 0 comments

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version:
  • Python version:
  • Operating System:

Error Description

In the _get_num_rows_from_parent method in the hierarchical sampler, we have a check to see if the the num_rows column for the child is present in the parent. The _sample_children method also implements a similar check in #1696.

What, if any, examples are there where this check fails? Can these check be safely removed?

frances-h avatar Nov 30 '23 22:11 frances-h