Copulas icon indicating copy to clipboard operation
Copulas copied to clipboard

Alpha and Beta can be out of bounds for beta distribution causing Nans to appear

Open lajohn4747 opened this issue 2 years ago • 0 comments

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • Copulas version: 0.9.2.dev1
  • Python version: 3.11
  • Operating System: Mac

Error Description

ppf function here returns a Nan if alpha and beta values are not within bounds (i.e. value > 0): https://github.com/sdv-dev/Copulas/blob/64a91e8ec3ffd8f0b7fa5e2f687eeabc430c3dd9/copulas/univariate/base.py#L582

This is causing issues where Nans are appearing in synthetic data where the original data does not contain nans.

Values are being passed in from here: https://github.com/sdv-dev/SDV/blob/71d61d6e8b01808c9b5a70b4573fdc7e1749b758/sdv/single_table/copulas.py#L345

lajohn4747 avatar Oct 12 '23 18:10 lajohn4747