sds
Adding Signature History Support
This is in reference to #300
I am very inexperienced with ruby, so I've probably done some strange / wrong things here, would love your feedback on anything like that.
I also haven't written tests yet. I wanted to get this up here and gather any feedback on the approach, and I have a couple of questions
- Should I remove the .git/config based stuff all together? I considered doing this, but decided not to in the thought that keeping it in place meant that I could basically guarantee that we weren't affecting performance very much.
- I couldn't find any tests for the configuration stuff, which seems to have been duplicated from hook_signer (well one was duplicated from the other at least). Did I just miss those? I assume I should write some if they don't already exist
- Feedback on writing tests? I was thinking: Check that if you sign a new signature and then return to an old signature, that it doesn't think the configuration has changed. I wasn't necessarily going to peak into the files for the tests, but rather just test the class interface.
- What is your commit / merging style? I normally commit a lot, but am happy to squash down to one commit if that is what you folks want
Obviously, not ready to merge, and just looking for feedback here.
Haven't had a chance to get back to this, all the comments make sense, just haven't had a chance to make tests
Totally understand – just showing my interest! Thanks for working on this!
I'm not using overcommit anymore (haven't in years, i'm going to close this PR, if anyone wants to take this over the line, feel free