Steven Atkinson

Results 212 comments of Steven Atkinson

Yep, this is a nice standard thing to do with convolutions. I want to think out loud through this. Putting this in here and NeuralAmpModelerCore will enable models to be...

Alright now, this was fun 😉

Yeah, I've seen this. There's a little discrepancy between how the validation step is computed and how that final prediction is run. In validation, the input is processed as-is and...

I've seen this before...https://github.com/sdatkinson/NeuralAmpModelerPlugin/issues/49 🙂 I'm willing to do this once https://github.com/sdatkinson/NeuralAmpModelerPlugin/issues/459 is addressed. Otherwise, adding this will cause the plugin to load incorrectly for everyone who's using the plugin...

Can you provide the rest of the info that the bug report template requests? > Wouldn't it be better to set precise versions in requirements to avoid sudden incompatibilities? Depends...

Could've sworn there was an Issue for this already. Regardless, yes, I'm open to this.

@flutomax the reason is that I started this project for fun, and it was more fun for me to write the code than to use someone else's 🙂 For sure,...

Every comment on every repo shows up as an email in my inbox. Please keep discussion here related to working on the Issues. To clarify, when I said > Could've...

I just happened to find this as I was on my way over here to request a feature for `torchaudio.functional.biquad`, which (TIL) uses `lfilter`. Just wanted to add a "+1"...