NeuralAmpModelerPlugin icon indicating copy to clipboard operation
NeuralAmpModelerPlugin copied to clipboard
verified publisher icon sdatkinson

[FEATURE] Toggle NAM on/off

Open joakimkl3 opened this issue 2 years ago • 7 comments

Many amp/stomp plugins have an on/off button that passes through a dry signal when turned off. This would be helpful when setting up midi controllers with some DAW and controller combos (e.g. M-VAVE Chocolate and Element).

joakimkl3 avatar Jan 18 '24 16:01 joakimkl3

This is very nearly "below the line" for me, but if it can be implemented the same way that the IR toggle currently is, would that be sufficient?

sdatkinson avatar Feb 05 '24 05:02 sdatkinson

That would be perfect. Then it would be possible to toggle the amp section using a program control (PC) midi event in Element in the same way as one can with the IR section. It would make the plugin complete ;)

joakimkl3 avatar Feb 05 '24 07:02 joakimkl3

Hi,

I haven't contributed yet into NAM but I would be able to implement this feature if @sdatkinson would be willing to merge it.

marmal95 avatar Aug 25 '24 16:08 marmal95

@marmal95 go for it!

sdatkinson avatar Sep 11 '24 01:09 sdatkinson

Sure, just a question about how it's supposed to work.

  1. Only NAM model is toggled (similarly to IR) - in such case, as I understand, EQ would be still applicable when enabled and IR.
  2. Whole plugin should be toggled (so e.g. by clicking on NAM logo we disable it completely).
  3. Both options

marmal95 avatar Sep 11 '24 05:09 marmal95

Based on the original description, I would say that the second option corresponds to the desired feature.

joakimkl3 avatar Sep 11 '24 13:09 joakimkl3

PR created #494.

marmal95 avatar Sep 12 '24 16:09 marmal95