sdatkinson
[FEATURE] There should be a pre-defined folder for nam/ir files (on macOS at least)
Due to the macOS sandbox disk access is is limited to certain folders that are specified in an App's .entitlements files. For the standalone app, it's possible to specify these ourselves (there is a quite limited selection) see #250, but in a DAW they will be specified by the host app. It's common practice to store presets these days in the users "Music" folder with a subfolder for the product name.
I suggest using the folders ~/Music/NeuralAmpModeler/Models and ~/Music/NeuralAmpModeler/Impulses or similar.
Without this, the popupmenu and navigation controls that I added in #242 will fail if people try to load files outside the macOS sandbox, basically the menu will not be populated with adjacent files to the selected one, because all the posix file system APIs will fail outside the sandbox.
I wonder also, if providing a default .nam and a default IR in these folders would be good.
Sigh. Makes sense though.
Would this be fixed by the installer then? Or what's needed to resolve this? Eg I could imagine saying to people "Put your models in ~/Music/NeuralAmpModeler" and that'd be it?
@olilarkin let me know if this is actually blocking #242. In my mind, if we got that PR in and it at least worked on Windows, I'd be happy to figure out the Mac details like this separately (assuming it--hopefully!--wouldn't require a massive rewrite of the approach you've started)
Benefit to this is that others could start building for other issues that should follow the new controls patterns e.g. #264.
Ok. I'm happy to take care of both separately then. I don't require main to be completely stable after each PR--only at the points where I make tagged releases 🙂