CodeFormer
CodeFormer copied to clipboard
Incorrect positional embedding in Stage II.
As shown in the figure above, the authors claimed they adopted the sinusoidal positional embedding in their project. However, as shown in the code below, they use "nn.Parameter" instead.
https://github.com/sczhou/CodeFormer/blob/8392d0334956108ab53d9439c4b9fc9c4af0d66d/basicsr/archs/codeformer_arch.py#L182
I've encountered the same problem as well.