spatialdata icon indicating copy to clipboard operation
spatialdata copied to clipboard

Fix dataloader table names

Open LLehner opened this issue 1 year ago • 1 comments

The ImageTilesDataset class cannot be used if the table you want to work with is not called "table", since there are lines where this name is hard-coded, even though the class allows for a table_name to be specified.

An example where this fails is if you follow this tutorial but specify a different table name when creating the dataset.

This PR replaces instances of "table" with table_name.

LLehner avatar Aug 01 '24 14:08 LLehner

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (f9fd885) to head (69c9f34). Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/dataloader/datasets.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   89.95%   91.83%   +1.87%     
==========================================
  Files          44       44              
  Lines        6769     6770       +1     
==========================================
+ Hits         6089     6217     +128     
+ Misses        680      553     -127     
Files with missing lines Coverage Δ
src/spatialdata/dataloader/datasets.py 90.29% <80.00%> (+56.63%) :arrow_up:

... and 1 file with indirect coverage changes

codecov[bot] avatar Aug 01 '24 14:08 codecov[bot]

Thanks @LLehner for the contribution. Only minor adjustments were neeed. Merging now and fixing the docs before release.

LucaMarconato avatar Aug 06 '24 15:08 LucaMarconato