genomic-features icon indicating copy to clipboard operation
genomic-features copied to clipboard

Add gene annotations to anndata vars

Open emdann opened this issue 2 years ago • 5 comments

Closes #14

emdann avatar Apr 27 '23 13:04 emdann

Codecov Report

Merging #23 (e669b8b) into main (2398977) will decrease coverage by 0.98%. The diff coverage is 92.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   93.69%   92.72%   -0.98%     
==========================================
  Files           6        7       +1     
  Lines         333      371      +38     
==========================================
+ Hits          312      344      +32     
- Misses         21       27       +6     
Impacted Files Coverage Δ
src/genomic_features/annotate.py 89.18% <89.18%> (ø)
src/genomic_features/__init__.py 100.00% <100.00%> (ø)
src/genomic_features/ensembl/ensembldb.py 93.15% <100.00%> (-1.06%) :arrow_down:

codecov-commenter avatar Apr 27 '23 13:04 codecov-commenter

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Outstanding issues:

  • Dealing with common column names between var table and annotation table. Throw error?

emdann avatar Apr 27 '23 13:04 emdann

Looks good! I added a few minor comments :)

lauradmartens avatar May 08 '23 16:05 lauradmartens

@ivirshup wrt Ensembl version matching, the pbmc3k data was mapped with cellranger 1.1, but I am having a hard time matching this version to a Ensembl release.

I'm gonna use the data from scvi.data.heart_cell_atlas_subsampled which is mapped to cellranger 3.0.1 with hg38 which according to the old release notes corresponds to Ensembl release 93.

emdann avatar May 18 '23 21:05 emdann