sct
Excessive calls to api.github.com
Description
I have been trying to figure out what has been breaking my CI builds by getting my IP banned from api.github.com. GitHub limits api.github.com requests by IP if they are not authenticated (60 per hour). This app is a pretty big offender, it makes a request every 5 minutes. That alone is 20% of the API quota. I have hundreds of apps and build processes running, many of which hit the API as well.
Desired Behavior
In-app update notifications are nice to have but not essential, especially since many people (myself included) run the app in Docker. Update notifications are typically handled at the image or container level. It might make sense to make these checks optional or less frequent to avoid hitting API rate limits.
Additional Context
No response
Code of Conduct
- [x] I agree to follow Overseerr's Code of Conduct
Adding to this:
I blocked the calls to api.github.com to try to preserve some quota and this app just starts hammering the API. Not sure if there is a check the proper HTTP status code but this could ban people's IPs indefinitely. If you reach your limit and the app just starts hammering the API.
It looks like it's hitting the Github API to check for updates, every time /api/v1/status is called
Way more frequently that 5 mins for me, but it's getting cached by the browser, so maybe 5 mins is cache TTL
Is Overseerr frontend trying to use this endpoint as a healthcheck to the backend? Might be worth splitting out a separate /health endpoint that doesn't call out to Github
Also related to: #3918
