sct
feat: request 4K media with the title card
Description
The main focus of this PR is to give the user the ability to request 4K media on the discover screen. Before, users were only able to request non-4K media through the title card. Now if non-4K media is already available and the server has 4K requesting enabled, the 4K request button will show. Also, a status badge will now show if you only have 4K media available.
There are some cases where the user might not have a non-4K server and two 4K servers so a check was added for this scenario.
- Movie enabled and series enabled boolean added to mirror the similar 4K booleans.
- 4K request modal was added to the title card.
Screenshot (if UI-related)
To-Dos
- [x] Successful build
yarn build
Issues Fixed or Closed
- Fixes #3482
- Fixes #3780
1 flaky test on run #2112 ↗︎
 0 |
 28 |
 0 |
 0 |
 1 |
Details:
| feat: request 4K media with the title card | |||
| Project: overseerr | Commit: 3369adfb9a |
||
| Status: Passed | Duration: 05:23 💡 | ||
| Started: Oct 2, 2023 5:27 PM | Ended: Oct 2, 2023 5:32 PM | ||
cypress/e2e/settings/discover-customization.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Discover Customization > can create a new discover option and remove it |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #3636 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't think this feature fully works. It does on the "Discover" tab, but on the "Movies" tab any 4K content doesn't have the available check mark. Example.
First, "Fight Club", a 1080p movie:
Checkmark shows on movie cover. Next, "Wonka" a 4K movie:
No checkmark. Only when you click into the movie does it show "4K Available"
Unless I'm missing something, the behavior should show the available check mark as long as any version is available.
Hmmmm just tested this on my end and it's working fine. The title card on discover and the movies tab use the same component. Not sure what is going on from your side to be honest.
Ok, sorry everyone. I'm on develop docker container version but didn't realize this has not been pushed yet.
Is there an easy way I can pull a docker container containing this update?
Majority of my content is 4K and it is very difficult to browse without the available icon.
I don't think this feature fully works. It does on the "Discover" tab, but on the "Movies" tab any 4K content doesn't have the available check mark. Example. First, "Fight Club", a 1080p movie:
Checkmark shows on movie cover. Next, "Wonka" a 4K movie:
No checkmark. Only when you click into the movie does it show "4K Available"
Unless I'm missing something, the behavior should show the available check mark as long as any version is available.
Hmmmm just tested this on my end and it's working fine. The title card on discover and the movies tab use the same component. Not sure what is going on from your side to be honest.
It works only if there is a 1080p AND 4K version.
Can you post a screenshot where it shows the checkmark with only the 4K version available?
The checkmark for 4K only content shows only when I manually mark the movie as Available here:
Only then does the available checkmark show. I did the same manual update to "Oppenheimer", but before, no checkmark with only the 4K version:
I am 1.33.2 stable release.
I mean of course it isn't going to work. This is still a PR. It hasn't been merged yet
Yes I didn't realize at the time. Apologies for that and I've edited my posts everywhere to reflect.
Thank you for adding this though, this feature would be amazing to have since the majority of my library is 4K. I get bad requests for 1080p content when the 4K exists simply because users can't easily tell that it already exists.