overseerr icon indicating copy to clipboard operation
overseerr copied to clipboard

fix: availability sync requests

Open OwsleyJr opened this issue 2 years ago • 3 comments

Description

Pretty big change coming with this new PR!

The highlight of this PR is two new statuses, deleted and completed. All requests will now be set to completed if the media is set to available or deleted. Specifically, when media is deleted, we can set that specific media status to deleted and, if the request isn't already complete, the relating media request to completed. This will prevent request deletion from the database and we can keep a history of all requests, even if they were deleted.

The second thing to mention is we now can subscribe to the media request entity for notifications instead of the media entity. Whenever a request is updated to completed, a check is made and if the media is available, send the notification. This vastly simplifies the handling of sending notifications if the media is available.

  • New Media status: DELETED and MediaRequest status: COMPLETED.
  • Entities Media, Season, and SeasonRequest will handle request completion with AfterUpdate method.
  • baseScanner updated to handle new DELETED status.
  • RequestButton, RequestModal, StatusBadge, etc. updated to handle new DELETED and COMPLETED status.
  • New MediaRequestSubscriber will now handle triggering media available notifications instead of MediaSubscriber.

Screenshot (if UI-related)

Title card deleted status

Screenshot 2023-05-22 at 12 21 06 AM

Media status deleted status

Screenshot 2023-05-22 at 12 20 55 AM

Request completed status

Screenshot 2023-05-22 at 12 21 16 AM

To-Dos

  • [x] Successful build yarn build
  • [x] Translation keys yarn i18n:extract

OwsleyJr avatar May 21 '23 01:05 OwsleyJr

Passing run #2239 ↗︎

0 28 0 0 Flakiness 0

Details:

fix: availability sync requests
Project: overseerr Commit: 44901b3e4f
Status: Passed Duration: 02:31 💡
Started: Dec 6, 2023 1:37 AM Ended: Dec 6, 2023 1:40 AM

Review all test suite changes for PR #3460 ↗︎

cypress[bot] avatar May 21 '23 01:05 cypress[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 06:10 stale[bot]

Hi !

Will this change allow any user to re-request a content if the availability status is deleted ? If so, I'm really interested in having this change merged, to me it's the only thing lacking in the current availability sync feature.

Can we expect this to be delivered in next release ?

axel-lebourhis avatar Dec 28 '23 20:12 axel-lebourhis