drummerSupport icon indicating copy to clipboard operation
drummerSupport copied to clipboard

Sorting out extra copies of Drummer left running

Open scripting opened this issue 4 years ago • 16 comments

Here's the background for this thread.

scripting avatar Dec 14 '21 23:12 scripting

I'm willing to help test this when it's time.

akaKenSmith avatar Dec 15 '21 03:12 akaKenSmith

I can help test this. Sounds like a nice plumbing job!

scotthansonde avatar Dec 15 '21 14:12 scotthansonde

@scotthansonde -- it is plumbing.

scripting avatar Dec 15 '21 14:12 scripting

@scotthansonde -- we're ready to begin the test. Is this the account you want to use for the test?

scripting avatar Dec 20 '21 16:12 scripting

@scripting Yes it is. I renamed my GitHub account a week ago. (Otherwise I'd be soon be grandpapascott 😄 )

scotthansonde avatar Dec 20 '21 16:12 scotthansonde

To be clear, it's the Twitter name that I need to know. My mistake. (Congrats on the addition to your family.)

scripting avatar Dec 20 '21 16:12 scripting

Here's the first test of two.

  1. You need two or more computers.

  2. Start Drummer in two tabs on the first machine.

  3. Start Drummer on the second machine.

  4. Verify that the first Drummer you opened on the first machine shows the About Drummer doc and the tab on the second machine shows Drummer. In other words you should see the original behavior.

Once you verify, I will let you know how to do the second test.

scripting avatar Dec 20 '21 16:12 scripting

Ah, the Twitter name is ScottHansonDE, that's unchanged. (And there's no planned addition to the family yet, but I'd be old enough for it!)

scotthansonde avatar Dec 20 '21 16:12 scotthansonde

@scotthansonde -- please let me know when you've done the first test. I will then change the software so you'll get the new behavior.

scripting avatar Dec 20 '21 17:12 scripting

The first test was unsuccessful. I have two computers, kirby and kepler (Twins baseball players 😄 ). I first logged into kirby over Remote Desktop, started Drummer in Safari, and logged into ScottHansonDE. I then switched back to my MacBook Pro kepler. I opened Chrome, started Drummer. The previous instance did not show the About Drummer doc. (Screen shot shows Remote Desktop in the background, local Mac in the foreground.)

CleanShot 2021-12-20 at 18 10 41

scotthansonde avatar Dec 20 '21 17:12 scotthansonde

I actually updated the app so you will not see the old behavior. So forget the first test.

The second test will follow...

scripting avatar Dec 20 '21 17:12 scripting

If you're able to test the new functionality, post your Twitter username here, the one you use with Drummer.

scripting avatar Dec 20 '21 17:12 scripting

Twitter user, sabre23t, tested the new functionality. First, I open drummer.scripting.com on my desktop. Then I open drummer.scripting.com on my phone. The copy on my desktop gets a dialog box "Drummer is running in another tab. you must reload this one, or -- you can safely close it". I press OK on the dialog on the desktop, it reloads. Now, almost immediately the drummer copy on my phone gets similar "Drummer is running in another tab..." dialog. Works great, I think. 😄

sabre23t avatar Dec 21 '21 13:12 sabre23t

If it's okay to carry out the test with a computer and an iPad, I'm ready. Twitter: @KenSmith

akaKenSmith avatar Dec 21 '21 15:12 akaKenSmith

@akaKenSmith -- yes of course -- the iPad is a computer.

scripting avatar Dec 21 '21 15:12 scripting

Using a Macbook and an iPad, I was able to get the "you've got two tabs going" message successfully, as @sabre23t described above. Looks good from here, many thanks.

akaKenSmith avatar Dec 21 '21 16:12 akaKenSmith