Scribe-iOS icon indicating copy to clipboard operation
Scribe-iOS copied to clipboard

Added explanation for conjugations missing from Wikidata (#400)

Open Jag-Marcel opened this issue 1 year ago • 4 comments

Contributor checklist


Description

When a word is present in Wikidata, but doesn't have any data for conjugation, the buttons in the conjugation screen show "Not in Wikidata" in the specific keyboard's language instead. Here I added a little info symbol to these buttons. Clicking them now leads the user to an info view describing how Scribe data is fetched from Wikidata, the same one used when entering a word missing from the database.

Example:

image image

Related issue

  • #400

Jag-Marcel avatar Apr 23 '24 18:04 Jag-Marcel

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you!

Maintainer checklist

  • [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • [ ] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

github-actions[bot] avatar Apr 23 '24 18:04 github-actions[bot]

Minor note on unexpected behavior, @Jag-Marcel :) If you have a conjugation option and then navigate to a tense that for the same cell doesn't have an option and thus an (i), but then navigate back, then the (i) will then be on the option. See screenshot:

Simulator Screenshot - iPhone 15 Pro Max - 2024-05-04 at 00 39 21

andrewtavis avatar May 03 '24 22:05 andrewtavis

Aside from the above, all's really wonderful, @Jag-Marcel! Let me know if there's anything I can do to help with the icon being displayed on conjugations :)

andrewtavis avatar May 03 '24 22:05 andrewtavis

Quick comment from the sync: let's also reduce the font size a bit and grey out the text 😊

andrewtavis avatar May 04 '24 14:05 andrewtavis

Just a quick note that we do need to figure out the corners changing their radius for this :)

andrewtavis avatar May 18 '24 14:05 andrewtavis