screwdriver icon indicating copy to clipboard operation
screwdriver copied to clipboard

Pipeline buildCluster annotation is not deleted

Open yuichi10 opened this issue 2 years ago • 2 comments

What happened:

If the user sets the `screwdriver.cd/buildCluster' annotation to pipeline level, even if the user deletes the setting, the setting is not deleted.

What you expected to happen:

It will run on the default build cluster if you remove the pipeline level annotation.

How to reproduce it:

  1. set the pipeline level screwdriver.cd/buildCluster annotation.
  2. remove the annotation.
  3. run build and the build will run on the cluster you set in the first step.

yuichi10 avatar Aug 04 '23 02:08 yuichi10

we save buildCluster into the Pipeline table at creation time of if the annotation changes. What should be the behavior once annotation is removed ? Let SD reset it to default ?

jithine avatar Aug 04 '23 15:08 jithine

Resetting to default seems to be a good idea.

yuichi10 avatar Aug 16 '23 03:08 yuichi10