scratchdata icon indicating copy to clipboard operation
scratchdata copied to clipboard

AWS Secret Manager for DB credentials

Open mehulmathur16 opened this issue 1 year ago • 10 comments

/claim #126 /fixes #126

Hi @poundifdef, I have tested out the memory vault & aws vault & it is working as expected.

The aws config looks like this :

vault:
  type: aws
  settings:
    AccessKey: "YOUR_AWS_ACCESS_KEY"
    SecretKey: "YOUR_AWS_SECRET_KEY"
    Prefix: "YOUR_PREFIX"
    Region: "us-east-1"

mehulmathur16 avatar Mar 24 '24 06:03 mehulmathur16

The below video shows the working with both vaults.

https://github.com/scratchdata/scratchdata/assets/64700961/90f70c22-e7e6-43f7-b1bd-f53900e43391

On AWS console:

image image

mehulmathur16 avatar Mar 24 '24 07:03 mehulmathur16

Hi @poundifdef, can you please review this PR ?

mehulmathur16 avatar Mar 25 '24 03:03 mehulmathur16

Hi @poundifdef, I have resolved the above comments. Can you please review ?

mehulmathur16 avatar Mar 25 '24 19:03 mehulmathur16

Hi @poundifdef , can you please review the updated changes ?

mehulmathur16 avatar Mar 26 '24 18:03 mehulmathur16

I haven't forgotten, I'll be sure to let you know when I've tested. Thanks!

poundifdef avatar Mar 27 '24 13:03 poundifdef

Sure @poundifdef 👍

mehulmathur16 avatar Mar 27 '24 13:03 mehulmathur16

Hi @poundifdef, There appear to be a lot of structural changes on main branch. My work was based on the old structure as described by you in the issue description. Can you tell if the requirements are a bit changed now ?

Could you please provide an update on the direction we are heading with regard to this issue?

mehulmathur16 avatar Mar 29 '24 14:03 mehulmathur16

@poundifdef I have resolved your comments. Please have a look.

mehulmathur16 avatar Mar 31 '24 15:03 mehulmathur16

@poundifdef are we good to go with the updated changes ?

mehulmathur16 avatar Apr 02 '24 17:04 mehulmathur16

Looks good. Thank you.

poundifdef avatar Apr 04 '24 12:04 poundifdef