AWS Secret Manager for DB credentials
/claim #126 /fixes #126
Hi @poundifdef, I have tested out the memory vault & aws vault & it is working as expected.
The aws config looks like this :
vault:
type: aws
settings:
AccessKey: "YOUR_AWS_ACCESS_KEY"
SecretKey: "YOUR_AWS_SECRET_KEY"
Prefix: "YOUR_PREFIX"
Region: "us-east-1"
The below video shows the working with both vaults.
https://github.com/scratchdata/scratchdata/assets/64700961/90f70c22-e7e6-43f7-b1bd-f53900e43391
On AWS console:
Hi @poundifdef, can you please review this PR ?
Hi @poundifdef, I have resolved the above comments. Can you please review ?
Hi @poundifdef , can you please review the updated changes ?
I haven't forgotten, I'll be sure to let you know when I've tested. Thanks!
Sure @poundifdef 👍
Hi @poundifdef, There appear to be a lot of structural changes on main branch. My work was based on the old structure as described by you in the issue description. Can you tell if the requirements are a bit changed now ?
Could you please provide an update on the direction we are heading with regard to this issue?
@poundifdef I have resolved your comments. Please have a look.
@poundifdef are we good to go with the updated changes ?
Looks good. Thank you.