[MRG+1] Import scurl if found installed
Hey @lopuhin, I made this PR to run scurl test on w3lib itself. Let me know if there's something that can be improved here π
I noticed that there's an error on py33 in travis build. I think it's because tox does not support py33 anymore (https://tox.readthedocs.io/en/latest/install.html) Can you take a look at this for me when you have a chance @kmike ? π
Codecov Report
Merging #110 into master will decrease coverage by
0.07%. The diff coverage is100%.
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 95.43% 95.35% -0.08%
==========================================
Files 7 7
Lines 482 474 -8
Branches 98 95 -3
==========================================
- Hits 460 452 -8
Misses 15 15
Partials 7 7
| Impacted Files | Coverage Ξ | |
|---|---|---|
| w3lib/url.py | 97.96% <100%> (-0.08%) |
:arrow_down: |
| w3lib/encoding.py | 100% <0%> (ΓΈ) |
:arrow_up: |
travis also gives the same error on master branch: https://travis-ci.org/nctl144/w3lib
Hey @lopuhin , I just added the echo command in the scurl envs so that we know that it's supposed to be installed and tested in SCURL testing env. :-) Let me know what you think!
I just added the echo command in the scurl envs so that we know that it's supposed to be installed and tested in SCURL testing env. :-) Let me know what you think!
@nctl144 sorry that I didn't respond right away, please see https://github.com/scrapy/w3lib/pull/110#discussion_r206421735
@lopuhin I just changed the echo command to python -c "from scurl import canonicalize_url" to make sure it's imported successfully π
@nctl144 Iβm sorry that it has been a year. Do you think you will have time to resolve the current conflicts?
Hey @Gallaecio , I will try to take a look into it and I will let you know as soon as I can :) Sorry for the delay in response
Bumping to close outdated PR.