fs2open.github.com icon indicating copy to clipboard operation
fs2open.github.com copied to clipboard

A theoretical fix for invalid checks

Open JohnAFernandez opened this issue 3 years ago • 1 comments

Replace wingp->num_waves == 0 with valid wingp->current_wave >= wingp->num_waves and correct a six year old copy paste error.

This will need testing to make sure it helps red alert work as expected.

Because this is basically contrary to how it has worked for 22.2 up to now, and it might disrupt some mod development somewhere, I am putting a waiting for stable flag on it.

closes #4269

JohnAFernandez avatar Jun 30 '22 15:06 JohnAFernandez

It is probably correct. The only thing keeping this in draft is a sanity test to make sure it works as expected. My testing set up has been non existent going on 6 months. (pre built laptop fell apart after about a year of use)

If there is an intrepid tester out there, please feel free to give it a whirl until I can get something set up.

JohnAFernandez avatar Sep 17 '22 13:09 JohnAFernandez

Ok, based on discussions with dahblount on discord, our new approach is to save wing info separately to make sure wing info persists properly.

JohnAFernandez avatar Sep 01 '23 22:09 JohnAFernandez