Develop

[vivonk]

Merging develop with the master branch

Description

changes to merge -

1. GSoC work -

• Download feature for single/multiple files where the files are compressed in a single file. #464, #465, #472
• Files could be shared with a single link and link could be generated from front end itself. Whenever someone creates a sharing link, it will compress those files in a single zip file and save it to a temp folder and when the user hit that link, the file will be sent. #479
• Created a grid view of downloaded files on front end side for a better look #463
• Separated declaration of endpoints and it's logic, basically mappings are declared in a single module where logical parts are in different modules. #475

Screenshots (In case of UI changes):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [x] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests pass.

[vivonk]

I guess most of the features, issues that we decided on version v.1.0 are implemented and fixed. So can we discuss v.1.0 release?

[agentmilindu]

@vivonk Yes, I think this is the high time for us to think about the version 1.0.0 release. Let's go through the project board and finalize everything. Let's take this week as the hardening sprint by fixing small bugs, adding minor improvements, improving the documentation, etc.

As we have a lot of people interested in becoming GCI mentors, we can get their help too in this.

[agentmilindu]

@vivonk The Lint error in the Codacy are possible GCI tasks. Can you work on this? Like, add tasks to fix lint errors in each file kinda tasks?

Maybe a task like "Fix lint errors in components/core/Server.py", etc or maybe "Fix list errors in one file" and make the task count 5.

[vibhorgupta-gh]

@agentmilindu could we make a task to add lint config in components/core as well as in ui?

[vivonk]

@agentmilindu sure, I will make tasks out of this. @VibhorCodecianGupta nice idea

[vibhorgupta-gh]

@vivonk I was creating the task now. Let's avoid duplication, we could discuss what it would entail? I had in mind ESLint for UI and Pylint for the backend. Thoughts?

[vivonk]

@agentmilindu @malithsen @rehrumesh I guess this is the time to sync develop and master

[vivonk]

@agentmilindu @rehrumesh @rajikaimal @malithsen @charithccmc Hi guys, we haven't sync our master branch from a long. So I request you to review it for once, just as go through if you find anything odd. I will be reviewing all the components and code-blocks one by one.

[kmehant]

@vivonk we might need to fix Codacy errors

[agentmilindu]

@JaDogg I guess we have to merge this and make master and develop synced soon

[JaDogg]

@agentmilindu yeah... we need to merge this so we can make a release. 😁😁 This sure is a big merge

[kmehant]

@JaDogg @agentmilindu ToDo:

1. #921 have to merge this
2. some commits are made to master which are not there on develop mostly the funding ones to be cherry-picked to this branch
3. Finally Merging this :)

[TravisBuddy]

Hey @vivonk,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: abc613b0-aa42-11ea-9064-4d6590cbb359

[kmehant]

@JaDogg With two approving reviews we can directly update this branch with the master here itself so it will be ready to be merged.