s2i-ruby-container icon indicating copy to clipboard operation
s2i-ruby-container copied to clipboard

Get rid of bundler deprications

Open jontrossbach opened this issue 4 years ago • 8 comments

Bundler 2 deprecated multiple flags and is backwards compatible only back to 2.3.0.

This is how I interpreted the updates.

jontrossbach avatar Aug 12 '21 23:08 jontrossbach

Thanks for the PR!

On a brief look it looks good, but please drop the changes for unsupported Ruby versions (they're there for archive purposes only).

Please also note that Ruby containers have various Bundler versions, so the syntax may not be supported by some older versions (e.g. 1.X).

pvalena avatar Aug 17 '21 18:08 pvalena

There's also Ruby 3.0 I think you've not covered.

pvalena avatar Aug 17 '21 18:08 pvalena

[test]

pvalena avatar Aug 17 '21 18:08 pvalena

Thanks @pvalena! I amended my interpretation of the changes you recommended to this commit. Let me know if you have anymore feedback.

jontrossbach avatar Sep 01 '21 21:09 jontrossbach

[test]

jontrossbach avatar Sep 05 '21 20:09 jontrossbach

[test]

phracek avatar Sep 06 '21 07:09 phracek

[test][test-openshift]

I hope we run the tests still the same way.

Thinking about it. Let's not disrupt existing containers. @jackorp maybe implement this for 3.1? :)

pvalena avatar Jul 04 '22 12:07 pvalena

@jackorp I've tried this in my fork / branch, and it seems to work. Anything against using this for 3.1?

#413

pvalena avatar Jul 12 '22 14:07 pvalena

@jontrossbach @pvalena Please if this pull request is still valid, rebase it against master and add to the newest versions like 'ruby-3.1'.

Otherwise close this issue.

phracek avatar Aug 23 '23 12:08 phracek

I've tried this in my fork / branch, and it seems to work. Anything against using this for 3.1?

Look like we already have it in 3.1 and 3.0 through other commit. +1 for closing.

jackorp avatar Aug 23 '23 12:08 jackorp