postgresql-container icon indicating copy to clipboard operation
postgresql-container copied to clipboard

Check for generated files by distgen

Open phracek opened this issue 4 years ago • 3 comments

This commit allows checking files generated by dist-gen.

If files are not generated properly, then the test fails.

phracek avatar Nov 29 '21 15:11 phracek

Would be much better to add a test for this part of the https://github.com/sclorg/container-common-scripts/blob/master/test.sh script. That way it would only be checked during the test upstream (or locally), it would fail very early (before the rest of the tests is run) and we would not have to add a test case to every single repository (a submodule update would be enough). @phracek WDYT?

pkubatrh avatar Nov 29 '21 15:11 pkubatrh

@pkubatrh you are right. Just update container-common-scripts and check if files are generated properly before any other tests, makes sense.

phracek avatar Nov 30 '21 11:11 phracek

@pkubatrh The container-common-scripts repository contains pull request where before calling any test generated files are checked. https://github.com/sclorg/container-common-scripts/pull/218

phracek avatar Dec 01 '21 12:12 phracek

This pull request is not needed at all. We have PR https://github.com/sclorg/container-common-scripts/pull/275 which does it automatically.

phracek avatar Sep 05 '22 07:09 phracek