scijava-common icon indicating copy to clipboard operation
scijava-common copied to clipboard
verified publisher icon scijava

Reconcile POM.compareVersions and VersionUtils.compare

Open stelfrich opened this issue 7 years ago • 3 comments

The two implementations (POM.compareVersions() and VersionUtils.compare()) are semantically identical and should be reconciled.

  • [ ] Deprecate POM.compareVersions()
  • [ ] Use VersionUtils.compare() in POM.compareTo()
  • [ ] Keep Javadoc of POM.compareVersions()
  • [ ] Keep implementation of VersionUtils.compare()

If you agree, @ctrueden, you can assign me and I can work on it.

stelfrich avatar Aug 03 '18 05:08 stelfrich

I agree in broad strokes. Let's wait a couple of weeks until I have the scaffold for SciJava 3 modularization in place. Then we can do the reconciliation there.

ctrueden avatar Aug 23 '18 21:08 ctrueden

Agreed! :+1:

stelfrich avatar Aug 24 '18 04:08 stelfrich

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/read-version-from-jar-file/40831/2

imagesc-bot avatar Jul 25 '20 13:07 imagesc-bot