flutter_cognito_plugin icon indicating copy to clipboard operation
flutter_cognito_plugin copied to clipboard

Cognito iOS SDK 2.18.1 (Bug Fix)

Open doc-rj-celltrak opened this issue 5 years ago • 3 comments

Hello, this is really a question more than an issue. I need to pick up a critical bug fix that went into the latest version 2.18.1 of the iOS SDK for Cognito -- https://github.com/aws-amplify/aws-sdk-ios/blob/main/CHANGELOG.md

The bug fix I need is here -- https://github.com/aws-amplify/aws-sdk-ios/issues/2886 The PR is here -- https://github.com/aws-amplify/aws-sdk-ios/pull/3190

The bug impacts iOS only, not Android.

It looks like the current podpsec for flutter_cognito_plugin points to version 2.13, so this will be a big jump to 2.18:

  s.dependency 'AWSMobileClient', '~> 2.13.0'
  s.dependency 'AWSAuth', '~> 2.13.0'
  s.dependency 'AWSCognito', '~> 2.13.0'
  s.dependency 'AWSAuthUI', '~> 2.13.0'
  s.dependency 'AWSUserPoolsSignIn', '~> 2.13.0'

I can open a PR and run the example app, but is there is any other recommendation on process to do the upgrade?

Thanks in advance for your help, and thanks again for the great library.

doc-rj-celltrak avatar Nov 09 '20 19:11 doc-rj-celltrak

I just noticed that the latest Android SDK release 2.19.1 has an important update for hosted UI support in all browsers, not just Chrome -- https://github.com/aws-amplify/aws-sdk-android/blob/main/CHANGELOG.md

This is definitely a feature we'd like to offer, so we may want to upgrade SDKs for both platforms.

doc-rj-celltrak avatar Nov 09 '20 20:11 doc-rj-celltrak

@doc-rj-celltrak are there any plans to make this update? thinking on using this lib but would be better to have the latest version.

Thanks!

danielocampo2 avatar Dec 10 '20 16:12 danielocampo2

A pod upgrade should theoretically let you upgrade to it without a change in this plugin, since 2.13 -> 2.18 is a minor change and the dependency is specified using the ~> operator.

PR welcome, regardless.

Sorry for the delay BTW.

devxpy avatar Dec 10 '20 16:12 devxpy