Eric Schweitz

Results 82 comments of Eric Schweitz

@ParamThakkar123 do you want to take another stab at this one?

Does this check prevent manually running the yml file? The original issue was logged because these scripts are "on by default". So if you have a fork, you have to...

So the solution is for original authors to create new forks?

[Undefined behavior](https://www.ibm.com/support/pages/assigning-negative-float-value-unsigned-integral-type-yields-undefined-value-stored-type#:~:text=Casting%20a%20negative%20float%20value,represented%20in%20the%20destination%20type.) I think the argument stated above is misleading. The quake code shown is _not_ the same as the C++ code and did not come from the C++ example....

This is pretty minimal already. The arith.truncf ought to be canonicalized out, but it may not be. It should also be a cc.cast. The LiftArrayAlloc pass will match the init_state...

Some of this is done. Mainly on the C++ side. More to do in the Python bridge.

The canonicalizer does not fold this `arith.truncf`, which then inhibits the constant folding of the `complex.create` because of a loss of precision.

It would be helpful to break out a list of actions to perform here.

List of files to audit includes: ```console ./Building.md ./tools/cudaq-quake/cudaq-quake.cpp ./tools/nvqpp/nvq++.in ./tools/cudaq-translate/cudaq-translate.cpp ./tools/cudaq-qpud/cudaq-qpud.py ./tools/cudaq-qpud/README.md ./tools/cudaq-opt/cudaq-opt.cpp ./Overview.md ./unittests/integration/adjoint_tester.cpp ./unittests/integration/ghz_nisq_tester.cpp ./.licenserc.yaml ./runtime/nvqir/NVQIR.cpp ./runtime/nvqir/CircuitSimulator.h ./runtime/common/BaseRestRemoteClient.h ./runtime/common/RuntimeMLIRCommonImpl.h ./runtime/cudaq/platform/default/rest/helpers/ionq/ionq.config ./runtime/cudaq/platform/default/rest/helpers/iqm/IQMServerHelper.cpp ./Contributing.md ./.devcontainer/devcontainer.json ./CITATION.cff ./Dev_Setup.md ./docker/release/cudaq.Dockerfile ./docker/release/cudaq.nvqc.Dockerfile...