postgrey icon indicating copy to clipboard operation
postgrey copied to clipboard

Sorted hostnames alphabetically + Whitelist some large pool

Open frugan-dev opened this issue 2 years ago • 5 comments

@schweikert Wouldn't it be a good idea to sort the records alphabetically, to make the file more readable?

frugan-dev avatar Feb 08 '24 00:02 frugan-dev

I personally prefer it to be sorted chronologically. You can always pass it through sort to see it alphabetically if you want.

fleish avatar Feb 29 '24 15:02 fleish

@fleish well.. we're using git: it handles the history!

frugan-dev avatar Feb 29 '24 16:02 frugan-dev

Well, sure we are using git here ... but I'm not running git on my mail servers

fleish avatar Feb 29 '24 16:02 fleish

@fleish IMHO we should think about what objectively makes sense at a global level, and not what we personally like at a local level. Even indicating the dates in the comments doesn't make much sense, since git takes care of keeping track of them

frugan-dev avatar Feb 29 '24 16:02 frugan-dev

I get your point of view, but also don't see how alphabetizing makes any more sense at a global level than the current sort method. There are also multiple ways this software gets distributed outside of git (even downloading the zip file from git excludes the actual git back-end data).

fleish avatar Feb 29 '24 18:02 fleish