Issues with ModSecurityIIS_2.9.1-64b.msi

[dedegoede]

It can't install a new version on top of the old one... It expected first to deinstall old version and then it can continue. From my perspective the msi should be able to upgrade or trace old version and remove it first (when this is a requirement) and then continue... I receive the following message:

Recipe: mod_security::install_base_iis
  * windows_package[ModSecurity IIS] action install
  Recipe: <Dynamically Defined Resource>
    * remote_file[C:\chef\cache\package\ModSecurityIIS_2.9.1-64b.msi] action cre
ate (up to date)

    ============================================================================
====
    Error executing action `install` on resource 'windows_package[ModSecurity II
S]'
    ============================================================================
====

    Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '1638'
    ---- Begin output of msiexec /qn /i "c:\chef\cache\package\modsecurityiis_2.
9.1-64b.msi"  /quiet /qn /passive ----
    STDOUT: A n o t h e r   v e r s i o n   o f   t h i s   p r o d u c t   i s
  a l r e a d y   i n s t a l l e d .     I n s t a l l a t i o n   o f   t h i
s   v e r s i o n   c a n n o t   c o n t i n u e .     T o   c o n f i g u r e
  o r   r e m o v e   t h e   e x i s t i n g   v e r s i o n   o f   t h i s
p r o d u c t ,   u s e   A d d / R e m o v e   P r o g r a m s   o n   t h e
C o n t r o l   P a n e l .
    STDERR:
    ---- End output of msiexec /qn /i "c:\chef\cache\package\modsecurityiis_2.9.
1-64b.msi"  /quiet /qn /passive ----
    Ran msiexec /qn /i "c:\chef\cache\package\modsecurityiis_2.9.1-64b.msi"  /qu
iet /qn /passive returned 1638

    Resource Declaration:
    ---------------------
    # In C:/chef/cache/cookbooks/mod_security/recipes/install_base_iis.rb

      9: windows_package node['mod_security']['package_name'] do
     10:   source node['mod_security']['url']
     11:   checksum node['mod_security']['checksum']
     12:   installer_type :msi
     13:   options "/quiet /qn /passive"
     14:   action :install
     15: end

[mwijers]

Sounds like an issue with the msi itself, not supporting upgrades. Windows_package doesn't seem to handle this and outputs the msi error 1638 "Another version of this product is already installed".