fixed-data-table-2 icon indicating copy to clipboard operation
fixed-data-table-2 copied to clipboard

Removing FixedDataTableCell div

Open Archit101967 opened this issue 2 years ago • 1 comments

Removing FixedDataTableCell div

Description

In this PR I have removed the div which was earlier used in FixedDataTableCell .Earlier the structure to render a cell was like FixedDataTableCell (div used for the cell container)->Type of Cell(Text cell,Date cell,Link cell,Image cell)->FixedDataTableCellDefault (div used for the text ) .But after the changes I have removed the div of FixedDataTableCell and the structure will be like FixedDataTableCell (no div used)->Type of Cell(Text cell,Date cell,Link cell,Image cell)->FixedDataTableCellDefault (div used for styling) .So I have provided all the styling and classnames to the FixedDataTableCell div only .And we have to also correct the resize and reorder cell rendering because their styling and functionalities will also get effected .

Motivation and Context

For optimising the performance of fixed-data-table-2

How Has This Been Tested?

Tested using our local examples

Screenshots (if appropriate):

Performance after removing that div Screenshot 2023-06-28 at 12 25 58 PM

Performance before removing that div Screenshot 2023-06-28 at 12 26 47 PM

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.

Archit101967 avatar Jun 28 '23 06:06 Archit101967

Can we group HOCs and legacy components in separate directory ?

AmanGupta2708 avatar Jun 28 '23 19:06 AmanGupta2708