fixed-data-table-2 icon indicating copy to clipboard operation
fixed-data-table-2 copied to clipboard

Reduce dom elements - Approach #2

Open Archit101967 opened this issue 2 years ago • 1 comments

Remove Cell Group div

Description

Earlier after div removal branch the structure of table to render any text in cell was table->row->CellGroup->Cell->Text where CellGroup will be either fixed, scrollable or fixed-right .In this Final div removal PR I changed the table structure to be Table->row->Cell->Text and remove one more div which was used for the styling of cell group .I provided props such as zIndex, scrollOffsetLeft (How much you have scrolled), offsetLeft and left to FixedDataTableCell so that I can directly style the cell and place it to the correct position .

Motivation and Context

For optimising the performance of fixed-data-table-2

How Has This Been Tested?

Tested using our local examples and performance dev tools

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.

Archit101967 avatar Jun 14 '23 20:06 Archit101967

Could you change base branch to column-virtualization

AmanGupta2708 avatar Jun 15 '23 04:06 AmanGupta2708