Tobias Munk comments

Results 511 comments of


                                            Tobias Munk

Empty "oneOf"

The editor should not crash, but the empty `oneOf` should also not be in the schema. If you remove it, it looks OK the me.

Add required star when table format

Could you add a test/use-case/example, I was unable to verify.

Add required star when table format

Could you add the `required` class for (all) the other themes also. I created a test here: https://github.com/json-editor/json-editor/commit/fe9923180bb6a5795e310286701bf00c5be55f1f (currently checks `spectre` and `bootstrap4`) Branch: https://github.com/json-editor/json-editor/compare/jneiluj-enhance-spectre-theme I think I can not...

Allow hidden=true for categorized object,

Do you also have a codeceptjs test, since there's a test page?

Allow hidden=true for categorized object,

Do you have Docker on your machine? Starting point for testing: https://github.com/json-editor/json-editor/tree/master/tests#testing

Allow hidden=true for categorized object,

I can't really help you with the setup. But are `@optional` tests excluded?

String input .on('change') not triggered on string input type

CC: @eluhr

Radio groups show multiple selections when use_name_attributes set to false.

@germanbisurgi Example: https://is.gd/54B3tM

show_opt_in controls parameter editor rendering according to parent object options

PRs welcome, but we also need tests.

Dynamic hide/show fields based on enum value

Could you provide an example? What do you mean with "too small"?