java-http-clj icon indicating copy to clipboard operation
java-http-clj copied to clipboard

File publisher support & tests

Open igrishaev opened this issue 1 year ago • 8 comments

As described in #10 , there is a pull-request to support File and Path body types. Tests added.

igrishaev avatar Dec 24 '24 09:12 igrishaev

Gentle ping? cc @schmee @borkdude

igrishaev avatar Dec 27 '24 07:12 igrishaev

@igrishaev I'm not the maintainer of this lib, but babashka.http-client started of with pretty much the code from this library and has had this feature since a long time:

https://github.com/babashka/http-client/blob/c4071b0a0918f88f79e91b154a5b5c09129c7bb4/src/babashka/http_client/internal.clj#L216-L222

borkdude avatar Dec 27 '24 09:12 borkdude

@borkdude That's really great you have that bits in your client, that's good to know. But the company I'm working for at the moment has built everything on top of java-http-clj.

igrishaev avatar Dec 27 '24 10:12 igrishaev

@schmee ping?

igrishaev avatar Jan 09 '25 16:01 igrishaev

@igrishaev hey, sorry for the delay, I completely missed this PR in my feed!

I haven't been active in the Clojure community for a long time and I don't even know if I can figure out how to release a new version of this library, but I will try to figure it out and if so, merge this and release a new version.

For the future, if you need more features than this library provides, I would suggest to migrate to the http client by @borkdude since he is one of the all-time greats of Clojure and remains very active in the community 😄

schmee avatar Jan 09 '25 17:01 schmee

@schmee that's alright, there were NY/Christmas holidays anyway. Yes I have plans to migrate our stuff to babashka/http-client in the future. But still, if you merge this PR and make a new release, that would be great.

igrishaev avatar Jan 09 '25 17:01 igrishaev

Maybe this can help: in my project.clj files, I usually have this:

  :deploy-repositories
  {"releases"
   {:url "https://repo.clojars.org"
    :creds :gpg}
   "snapshots"
   {:url "https://repo.clojars.org"
    :creds :gpg}}

  :release-tasks
  [["vcs" "assert-committed"]
   ["test"]
   ["change" "version" "leiningen.release/bump-version" "release"]
   ["vcs" "commit"]
   ["vcs" "tag" "--no-sign"]
   ["deploy"]
   ["change" "version" "leiningen.release/bump-version"]
   ["vcs" "commit"]
   ["vcs" "push"]]

and then I just run lein release

igrishaev avatar Jan 09 '25 17:01 igrishaev

@schmee gentle reminder... can you please merge it and make a release?

igrishaev avatar Feb 26 '25 17:02 igrishaev