java-http-clj icon indicating copy to clipboard operation
java-http-clj copied to clipboard

Willing to add a File publisher

Open igrishaev opened this issue 1 year ago • 0 comments

First of all, thanks for the library! I've been happily using it after switching from clj-http. It's a part of our S3 internal client.

One thing I've noticed is, it looks like the convert-body-publisher function doesn't take into account a case when the body is a File object. The HttpRequest.BodyPublishers class has a static method to handle files: . ofFile(Path path). This is a good case for s3 because most often, we upload File objects there.

My question is, will you accept my PR if I extend the convert-body-publisher function with something like:

...
(instance? java.io.File body)
(HttpRequest$BodyPublishers/ofFile (.getPath body))

UPD: https://github.com/schmee/java-http-clj/pull/11

igrishaev avatar Dec 24 '24 09:12 igrishaev