git-s3 icon indicating copy to clipboard operation
git-s3 copied to clipboard

ignore .DS_Store

Open edmundtfy opened this issue 8 years ago • 4 comments

Somebody has raised this in an open issues and I ran into it too. First time creating pull request, not sure how to reference to the issues. Here is the link: https://github.com/schickling/git-s3/issues/21 Thanks!

edmundtfy avatar Apr 05 '17 07:04 edmundtfy

Thanks a lot for this PR! Can you please fix the tests?

schickling avatar Apr 05 '17 14:04 schickling

@schickling sorry there! how do I run the test and fix them? Just pointing me to documentations would be nice :) by the way, I notice git-s3 would sometimes not upload some folders and I don't know why. Ever have such issues?

edmundtfy avatar Apr 19 '17 08:04 edmundtfy

@edmundtfy - did you fix?

johndpope avatar Jul 18 '18 14:07 johndpope

I presume the missing files might be due to a different region. This logic fix should be merged / cherry picked to master. https://github.com/Irishsmurf/git-s3/commit/f67f709afed0f33d7aaeaa840e9e64c5dd1023e9

johndpope avatar Jul 18 '18 15:07 johndpope