schemar
Bump major or minor version number?
The 20190917 branch will be changing the upstream version that is patched over when it is merged into master, so when that is done and a release is made, the question is is that a major or minor version bump?
Did arc make a new release? Did they bump major or minor version? Basically, we are not making any changes on our end, only pulling upstream. Right?
Unfortunately, their version number is just 20190917 =P
The only actual change our end really is dropping the patch files as they accepted them upstream prior to their latest release.
An argument could be made though for bumping the major, and using the minor for tracking any tweaks we then make. Or, for bumping the minor and using the revision number for changes our end. Something like SemVer doesn't really seem to apply as a scheme here, so it seems like we need to decide how the versions will change whenever we need to update against the upstream.
I would say that, generally, just pulling upstream would be a patch release. If we make changes on our end, it could be a major, minor, or patch change.
However, I would say it also depends on the changes that were made upstream. How significant are they?
- New GTK version? Probably new major version on our side.
- New environment added? Probably new minor version.
- Fixed some colors? Probably a patch release.
I think you should just judge from the changes to see how major you think the changes are. If you still want more input, I am of course available 😊
From https://github.com/arc-design/arc-theme/releases/tag/20190917 I would say it’s a minor version. But I think you know more and can better judge.