FloatingPanel icon indicating copy to clipboard operation
FloatingPanel copied to clipboard

Is it possible to use .half height but allow people to pull the panel farther?

Open warpling opened this issue 5 years ago • 6 comments

Is it possible to configure a panel with only a .half height anchor to be able to be pulled up (towards the top of screen) without providing a full-size anchor? I have tried overriding floatingPanelDidMove to allow the surface location to be anything, have shouldProjectMomentum and allowsRubberBanding enabled, yet can't seem to replicate this behavior. Am I missing something or is this not currently possible. Thanks!

warpling avatar Nov 06 '20 12:11 warpling

it might not be possible on occasion. Here is my repro steps.

  1. Comment out here: https://github.com/SCENEE/FloatingPanel/blob/master/Examples/Samples/Sources/ViewController.swift#L477
  2. Run Samples.app

and then,

"Scroll tracking(TextView)" and "Show Detail Panel" are OK. "Scroll tracking(TableView)" looks NG.

After investigating the above NG case, I found a code to be fixed about the scroll tracking. And then I made a patch in iss-401 branch. Could you please try it?

[Edit] I've force-pushed iss-401(15e9808) because I found some issues.

scenee avatar Nov 07 '20 03:11 scenee

I might wait to test this since it's so closely related to the relative anchor issue/PR.

warpling avatar Nov 10 '20 20:11 warpling

Any update to this?

alouanemed avatar Nov 19 '20 12:11 alouanemed

Hello @warpling, could you please check https://github.com/SCENEE/FloatingPanel/pull/407?

scenee avatar Dec 12 '20 02:12 scenee

Hey @SCENEE, sorry I never was able to test this. I hope someone else can confirm it is working! Perhaps unrelated, but I did recently notice that .full panels can now be dragged up to any height if they are initially pulled down; they cannot be dragged up and higher from .full if they have not been dragged down first.

warpling avatar Jan 28 '21 11:01 warpling

Thank you for your testing and sharing a problem, @warpling. I will investigate the following issue later.

they cannot be dragged up and higher from .full if they have not been dragged down first.

scenee avatar Jan 31 '21 00:01 scenee