Serge Camille

Sally7.Protocol.SizeOf looks nice. I would just blindly assume that my available payload in bytes for a read request is: var sizeAvailable = connection.Parameters.MaxPDU - SizeOf.ReadRequest - NumberOfDataItems * SizeOf.DataItem; Do...

Let me know if I should do part of the work for such a "Max Payload" calculator. I mainly wanted some of the internal sizes exposed so I don't have...

Oh and I guess just to be on the safe side: Is the overhead of sending the read request larger than the overhead required for receiving the response? In the...

S7NetPlus uses Snap7 in its unit tests. I think most of the code for that is in https://github.com/S7NetPlus/s7netplus/blob/develop/S7.Net.UnitTest/Helpers/S7TestServer.cs . Your implementation using Snap7.Managed might be better though. I was able...

The problem with the target compile definition in https://github.com/google/benchmark/blob/main/src/CMakeLists.txt#L58 is that it is PRIVATE and not PUBLIC. Thus when googlebenchmark as a lib is built, the define is correctly present,...

As far as I can tell, to provide relevant tank statistics at bloodmallet.com, the main goal is to increase the dimensions / options you have for each chart, just like...

I tried to look at bloody tools a bit: You could just change https://github.com/Bloodmallet/bloodytools/blob/d8c5f6dbdfdb7d189529c07d2d1f98a084ae116a/bloodytools/simulation_objects/simulation_objects.py#L274 to get_metric_results() and instead of just returning a single dps value, you would return {"dps": X,...

The fix is as simple as changing https://github.com/omry/omegaconf/blob/117f7de07285e4d1324b9229eaf873de15279457/omegaconf/nodes.py#L490 from `return enum_type[value]` to `return enum_type(value)` That change allows the enum to be constructed from strings through the [_missing_](https://docs.python.org/3/library/enum.html#enum.Enum._missing_) operator as well,...

Thanks for the response. I'll have to see if I can find the time, it might take a while :-)