scamacho23
Code repeated heavily throughout project
🐛 Describe the bug
Specifically, the issue is that several methods repeat code, so it would be best to decompose out helper functions to use.
Hi, I wanted to try liszt. I got getting segmentation fault error. I installed liszt on mac through brew. Am I missing something?
@s-surineni I'm not sure why that's happening to be honest -- did brew install v1.1.8? I know there was some compatibility issue between 1.1.7 and 1.1.8 with brew. For now, just do the git clone. I think that a merge I previously committed from another contributor may have introduced some breaking measures, so let me try and revert that.
@anujpatel224 have at it. As a I said above, still not sure why Liszt is breaking on install -- stick to the git clone for now.
Yes -- there are some weird issues with the build and I haven't gotten around to fixing them yet. I think git cloning the repo should avoid that but let me know if not.
Hi, I see this issue is still open. If that's the case, I would like to work on it if possible.
Absolutely @kitsiosvas -- I haven't worked on this lately so not sure what the build status is. I doubt using brew to install works but cloning the repo should be fine.
Thank you for your quick reply @scamacho23. I will inspect the code starting tonight even to locate the duplicates across the project. In case there is a list on where the duplicates are, I would highly appreciate it if I could be provided with this information.
@scamacho23 I've done some changes ( deleted duplicate code by calling a function) in the memory.c file. Where would you want me to commit the code/issue a pull request? The reason I'm asking is that don't want to do something that I shouldn't. Also will have some changes in the util.c file by tonight. Thank you.
@kitsiosvas You fork this repository, commit your changes in your fork and make a Pull Request (PR). See GitHub Docs for more details.
@rjthompson2 probably. ask @scamacho23 to be sure.
@scamacho23 Hello! I am a complete beginner in open source and am just starting out. This is my first commit in other's repository. I have created a pull request.
