metalk8s icon indicating copy to clipboard operation
metalk8s copied to clipboard

build: Add codegen for addons charts rendering

Open TeddyAndrieux opened this issue 3 years ago • 5 comments

Allow to use doit to generate the charts SLS, and also validate the generated SLS content in the CI

$ ./doit.sh list --all codegen
codegen                               Run the code generation tools.
codegen:chart_dex                     Generate the SLS file for Dex using the chart render script.
codegen:chart_fluent-bit              Generate the SLS file for fluent-bit using the chart render script.
codegen:chart_ingress-nginx           Generate the SLS file for NGINX Ingress using the chart render script.
codegen:chart_kube-prometheus-stack   Generate the SLS file for Kube Prometheus Stack using the chart render script.
codegen:chart_loki                    Generate the SLS file for Loki using the chart render script.
codegen:chart_metallb                 Generate the SLS file for MetalLB using the chart render script.
codegen:chart_prometheus-adapter      Generate the SLS file for Prometheus Adapter using the chart render script.
codegen:chart_thanos                  Generate the SLS file for Thanos using the chart render script.
codegen:metalk8s_operator             Generate Go code for the MetalK8s Operator using the Operator SDK Makefile.
codegen:storage_operator              Generate Go code for the Storage Operator using the Operator SDK Makefile.

NOTE: This is not the best approach the charts/render.py script should be migrated in the buildchain (or we should totally change the way to manage "addons" but ... you know :smile: ), but at least it's better than having the command in commit message :)

TeddyAndrieux avatar Sep 13 '22 17:09 TeddyAndrieux

Hello teddyandrieux,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e avatar Sep 13 '22 17:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @gdemonet

  • @chengyanjin

  • @teddyandrieux

  • @thomasdanan

  • @lucieleonard

  • @jbwatenbergscality

bert-e avatar Sep 13 '22 17:09 bert-e

/approve

TeddyAndrieux avatar Sep 16 '22 09:09 TeddyAndrieux

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @gdemonet

  • @chengyanjin

  • @teddyandrieux

  • @thomasdanan

  • @lucieleonard

  • @jbwatenbergscality

The following options are set: approve

bert-e avatar Sep 16 '22 09:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

  • @teddyandrieux

  • @jbwatenbergscality

  • @chengyanjin

  • @thomasdanan

  • @gdemonet

  • @lucieleonard

The following options are set: approve

bert-e avatar Sep 23 '22 07:09 bert-e

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

  • :heavy_check_mark: development/124.0

The following branches will NOT be impacted:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e avatar Sep 26 '22 08:09 bert-e

I have successfully merged the changeset of this pull request into targetted development branches:

  • :heavy_check_mark: development/124.0

The following branches have NOT changed:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

bert-e avatar Sep 26 '22 08:09 bert-e