Remove eslint custom rules and introduce prettier

[ghost]

We should follow the eslint default, completed by the imported scality rules.

Any additional rule should add some constraints, like disabling .only tests to make the CI fail.

The reason is that we end up being too leniant on the style, and that translates into useless indent (or other style) changes in branches, due to local tooling auto-formatting the code, which make the reviews harder.

The main problem reported is the indentation: it is varying from file to file, making the code harder to read.

Almost all rules were already followed, so enabling them was not impacting the code at all.

Then we introduce prettier to ensure code style is consistent.

Issue: CLDSRV-723

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	:star:
/bypass_build_status	Bypass the build and test status	:star:
/bypass_commit_size	Bypass the check on the size of the changeset TBA	:star:
/bypass_incompatible_branch	Bypass the check on the source branch prefix	:star:
/bypass_jira_check	Bypass the Jira issue check	:star:
/bypass_peer_approval	Bypass the pull request peers' approval	:star:
/bypass_leader_approval	Bypass the pull request leaders' approval	:star:
/approve	Instruct Bert-E that the author has approved the pull request.		:writing_hand:
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-723 contains:

• 9.0.22

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.0.21

• 9.1.0

Please check the Fix Version/s of CLDSRV-723, or the target branch of this pull request.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 76.66667% with 672 lines in your changes missing coverage. Please review.

Project coverage is 75.90%. Comparing base (e47d49e) to head (9254174).

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/objectGet.js	44.44%	70 Missing :warning:
lib/api/multiObjectDelete.js	62.42%	65 Missing :warning:
lib/api/objectCopy.js	73.88%	41 Missing :warning:
lib/api/objectPutCopyPart.js	70.64%	32 Missing :warning:
lib/api/objectPutPart.js	76.10%	27 Missing :warning:
lib/api/completeMultipartUpload.js	87.07%	19 Missing :warning:
lib/api/apiUtils/object/createAndStoreObject.js	74.64%	18 Missing :warning:
lib/api/metadataSearch.js	5.26%	18 Missing :warning:
lib/api/bucketGetEncryption.js	0.00%	17 Missing :warning:
lib/api/apiUtils/object/objectLockHelpers.js	34.78%	15 Missing :warning:
... and 72 more

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/Config.js	79.29% <ø> (+0.18%)	:arrow_up:
lib/api/apiUtils/bucket/bucketShield.js	100.00% <100.00%> (ø)
lib/api/apiUtils/bucket/createKeyForUserBucket.js	100.00% <ø> (ø)
...api/apiUtils/bucket/getReplicationConfiguration.js	90.90% <100.00%> (ø)
...b/api/apiUtils/bucket/validateReplicationConfig.js	84.61% <100.00%> (-1.10%)	:arrow_down:
lib/api/apiUtils/bucket/validateSearch.js	96.42% <100.00%> (ø)
lib/api/apiUtils/object/applyZenkoUserMD.js	80.00% <100.00%> (ø)
lib/api/apiUtils/object/checkHttpHeadersSize.js	88.88% <100.00%> (ø)
lib/api/apiUtils/object/checkReadLocation.js	100.00% <100.00%> (ø)
lib/api/apiUtils/object/checkUserMetadataSize.js	61.53% <100.00%> (-2.75%)	:arrow_down:
... and 160 more

@@                 Coverage Diff                 @@
##           development/9.0    #5877      +/-   ##
===================================================
+ Coverage            75.88%   75.90%   +0.02%     
===================================================
  Files                  188      188              
  Lines                11983    11957      -26     
===================================================
- Hits                  9093     9076      -17     
+ Misses                2890     2881       -9     

Flag	Coverage Δ
ceph-backend-test	47.00% <40.83%> (+0.06%)	:arrow_up:
file-ft-tests	47.35% <45.31%> (+0.03%)	:arrow_up:
kmip-ft-tests	27.03% <13.75%> (+0.05%)	:arrow_up:
mongo-v0-ft-tests	47.79% <45.45%> (+0.04%)	:arrow_up:
mongo-v1-ft-tests	47.81% <45.45%> (+0.04%)	:arrow_up:
multiple-backend	35.53% <18.22%> (+0.05%)	:arrow_up:
quota-tests	32.30% <24.02%> (-0.80%)	:arrow_down:
quota-tests-inflights	34.26% <30.00%> (+0.04%)	:arrow_up:
unit	66.95% <72.77%> (+<0.01%)	:arrow_up:
utapi-v2-tests	33.40% <28.92%> (+0.07%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-723 contains:

• 9.0.22

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.0.22

• 9.1.0

Please check the Fix Version/s of CLDSRV-723, or the target branch of this pull request.