remove hardcoded replicationGroupId and generate from pod name
- Removed the hardcoded default value 'RG001' for replicationGroupId.
- replicationGroupId is now generated from the Kubernetes pod name by taking the first 2 characters of the long hash and concatenating it with the full short hash (e.g., cloudserver-7869f99955-nr984 → 78nr984).
- Ensures uniqueness across deployments within the same namespace while keeping the ID short.
- Falls back to 'RG001' only if neither config nor HOSTNAME is available.
Note: We are limited to only 7 characters for the replicationGroupId in the versionID generation algorithm.
Issue: CLDSRV-665
Hello kerkesni,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Available options
| name | description | privileged | authored |
|---|---|---|---|
/after_pull_request |
Wait for the given pull request id to be merged before continuing with the current one. | ||
/bypass_author_approval |
Bypass the pull request author's approval | :star: | |
/bypass_build_status |
Bypass the build and test status | :star: | |
/bypass_commit_size |
Bypass the check on the size of the changeset TBA |
:star: | |
/bypass_incompatible_branch |
Bypass the check on the source branch prefix | :star: | |
/bypass_jira_check |
Bypass the Jira issue check | :star: | |
/bypass_peer_approval |
Bypass the pull request peers' approval | :star: | |
/bypass_leader_approval |
Bypass the pull request leaders' approval | :star: | |
/approve |
Instruct Bert-E that the author has approved the pull request. | :writing_hand: | |
/create_pull_requests |
Allow the creation of integration pull requests. | ||
/create_integration_branches |
Allow the creation of integration branches. | ||
/no_octopus |
Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | ||
/unanimity |
Change review acceptance criteria from one reviewer at least to all reviewers |
||
/wait |
Instruct Bert-E not to run until further notice. |
Available commands
| name | description | privileged |
|---|---|---|
/help |
Print Bert-E's manual in the pull request. | |
/status |
Print Bert-E's current status in the pull request TBA |
|
/clear |
Remove all comments from Bert-E from the history TBA |
|
/retry |
Re-start a fresh build TBA |
|
/build |
Re-start a fresh build TBA |
|
/force_reset |
Delete integration branches & pull requests, and restart merge process from the beginning. | |
/reset |
Try to remove integration branches unless there are commits on them which do not appear on the source branch. |
Status report is not available.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.11%. Comparing base (
b6a78b9) to head (17cab88). Report is 8 commits behind head on development/8.8.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/Config.js | 75.68% <100.00%> (+0.36%) |
:arrow_up: |
| lib/metadata/wrapper.js | 55.55% <ø> (ø) |
@@ Coverage Diff @@
## development/8.8 #5826 +/- ##
===================================================
+ Coverage 65.08% 65.11% +0.03%
===================================================
Files 188 188
Lines 11948 11961 +13
===================================================
+ Hits 7776 7789 +13
Misses 4172 4172
| Flag | Coverage Δ | |
|---|---|---|
| unit | 65.11% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Request integration branches
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.
Note for reviewers, i updated this PR following the changes in the TAD.
We no longer use the replicationGroupId as a local unique id but a new field called instanceId.
@Kerkesni do we want to target 8.8? Some clients might not be ready to upgrade to the latest product version right away
Request integration branches
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.
@williamlardier yes forgot about that part, thanks
/create_integration_branches
Integration data created
I have created the integration data for the additional destination branches.
- this pull request will merge
bugfix/CLDSRV-665intodevelopment/8.8 -
w/9.0/bugfix/CLDSRV-665 will be merged into
development/9.0 -
w/9.1/bugfix/CLDSRV-665 will be merged into
development/9.1
The following branches will NOT be impacted:
-
development/7.10 -
development/7.4 -
development/7.70
You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: create_integration_branches
History mismatch
Merge commit #cfba4d355c05814b43f9a5dd8b3d12f479547b48 on the integration branch
w/9.0/bugfix/CLDSRV-665 is merging a branch which is neither the current
branch bugfix/CLDSRV-665 nor the development branch
development/9.0.
It is likely due to a rebase of the branch bugfix/CLDSRV-665 and the
merge is not possible until all related w/* branches are deleted or updated.
Please use the reset command to have me reinitialize these branches.
The following options are set: create_integration_branches
/reset
Reset complete
I have successfully deleted this pull request's integration branches.
The following options are set: create_integration_branches
Integration data created
I have created the integration data for the additional destination branches.
- this pull request will merge
bugfix/CLDSRV-665intodevelopment/8.8 -
w/9.0/bugfix/CLDSRV-665 will be merged into
development/9.0 -
w/9.1/bugfix/CLDSRV-665 will be merged into
development/9.1
The following branches will NOT be impacted:
-
development/7.10 -
development/7.4 -
development/7.70
You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: create_integration_branches
/force_reset
Reset complete
I have successfully deleted this pull request's integration branches.
The following options are set: create_integration_branches
Integration data created
I have created the integration data for the additional destination branches.
- this pull request will merge
bugfix/CLDSRV-665intodevelopment/8.8 -
w/9.0/bugfix/CLDSRV-665 will be merged into
development/9.0 -
w/9.1/bugfix/CLDSRV-665 will be merged into
development/9.1
The following branches will NOT be impacted:
-
development/7.10 -
development/7.4 -
development/7.70
You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: create_integration_branches
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: create_integration_branches
History mismatch
Merge commit #e1fb0290322cc75e24b8e90c8fd2a9d4e6cd4177 on the integration branch
w/9.0/bugfix/CLDSRV-665 is merging a branch which is neither the current
branch bugfix/CLDSRV-665 nor the development branch
development/9.0.
It is likely due to a rebase of the branch bugfix/CLDSRV-665 and the
merge is not possible until all related w/* branches are deleted or updated.
Please use the reset command to have me reinitialize these branches.
The following options are set: create_integration_branches
/force_reset
Reset complete
I have successfully deleted this pull request's integration branches.
The following options are set: create_integration_branches
Integration data created
I have created the integration data for the additional destination branches.
- this pull request will merge
bugfix/CLDSRV-665intodevelopment/8.8 -
w/9.0/bugfix/CLDSRV-665 will be merged into
development/9.0 -
w/9.1/bugfix/CLDSRV-665 will be merged into
development/9.1
The following branches will NOT be impacted:
-
development/7.10 -
development/7.4 -
development/7.70
You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
The following options are set: create_integration_branches
/approve
In the queue
The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.
The changeset will be merged in:
-
:heavy_check_mark:
development/8.8 -
:heavy_check_mark:
development/9.0 -
:heavy_check_mark:
development/9.1
The following branches will NOT be impacted:
-
development/7.10 -
development/7.4 -
development/7.70
There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.
- Any commit you add on the source branch will trigger a new cycle after the current queue is merged.
- Any commit you add on one of the integration branches will be lost.
If you need this pull request to be removed from the queue, please contact a member of the admin team now.
The following options are set: approve, create_integration_branches
I have successfully merged the changeset of this pull request into targetted development branches:
-
:heavy_check_mark:
development/8.8 -
:heavy_check_mark:
development/9.0 -
:heavy_check_mark:
development/9.1
The following branches have NOT changed:
-
development/7.10 -
development/7.4 -
development/7.70
Please check the status of the associated issue CLDSRV-665.
Goodbye kerkesni.