Standard authorization for backbeat routes
Better review commit per commit
The goal here is to handle the authorization from the IAM module in the backbeat routes, and not rely on implicit deny === access denied, as this is not true anymore.
By doing so, we centralize the logic with all S3 APIs, and introduce some unit test to complete the functional tests from tests/multipleBackend/routes/routeBackbeat.js
Current state: functional tests for the ceph test suite and the ones using a real azure/aws/gcp are still not running because they were disabled long time ago, and the resources are not existing anymore, some are still there, but it will be done in a separate ticket.
Hello williamlardier,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Available options
| name | description | privileged | authored |
|---|---|---|---|
/after_pull_request |
Wait for the given pull request id to be merged before continuing with the current one. | ||
/bypass_author_approval |
Bypass the pull request author's approval | :star: | |
/bypass_build_status |
Bypass the build and test status | :star: | |
/bypass_commit_size |
Bypass the check on the size of the changeset TBA |
:star: | |
/bypass_incompatible_branch |
Bypass the check on the source branch prefix | :star: | |
/bypass_jira_check |
Bypass the Jira issue check | :star: | |
/bypass_peer_approval |
Bypass the pull request peers' approval | :star: | |
/bypass_leader_approval |
Bypass the pull request leaders' approval | :star: | |
/approve |
Instruct Bert-E that the author has approved the pull request. | :writing_hand: | |
/create_pull_requests |
Allow the creation of integration pull requests. | ||
/create_integration_branches |
Allow the creation of integration branches. | ||
/no_octopus |
Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | ||
/unanimity |
Change review acceptance criteria from one reviewer at least to all reviewers |
||
/wait |
Instruct Bert-E not to run until further notice. |
Available commands
| name | description | privileged |
|---|---|---|
/help |
Print Bert-E's manual in the pull request. | |
/status |
Print Bert-E's current status in the pull request TBA |
|
/clear |
Remove all comments from Bert-E from the history TBA |
|
/retry |
Re-start a fresh build TBA |
|
/build |
Re-start a fresh build TBA |
|
/force_reset |
Delete integration branches & pull requests, and restart merge process from the beginning. | |
/reset |
Try to remove integration branches unless there are commits on them which do not appear on the source branch. |
Status report is not available.
Incorrect fix version
The Fix Version/s in issue CLDSRV-591 contains:
- None
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
-
8.8.40
Please check the Fix Version/s of CLDSRV-591, or the target
branch of this pull request.
Waiting for approval
The following approvals are needed before I can proceed with the merge:
-
the author
-
2 peers
Incorrect fix version
The Fix Version/s in issue CLDSRV-591 contains:
-
8.8.40
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
-
8.8.40 -
8.9.0
Please check the Fix Version/s of CLDSRV-591, or the target
branch of this pull request.
Incorrect fix version
The Fix Version/s in issue CLDSRV-591 contains:
-
8.8.40
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
-
8.8.40 -
9.0.0
Please check the Fix Version/s of CLDSRV-591, or the target
branch of this pull request.
Incorrect fix version
The Fix Version/s in issue CLDSRV-591 contains:
-
8.8.41
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
-
8.8.41 -
9.0.0
Please check the Fix Version/s of CLDSRV-591, or the target
branch of this pull request.