cloudserver icon indicating copy to clipboard operation
cloudserver copied to clipboard
verified publisher icon scality

Improvement/cldsrv 281 complete missing permission checks

Open williamlardier opened this issue 3 years ago • 3 comments

This PR includes changes from Arsenal where we fixed the permission names to comply with AWS standard.

This PR is about adding all the missing permissions according to the work done in https://scality.atlassian.net/wiki/spaces/OS/pages/1984397327/Cloudserver+vs+AWS+permission+checks, with more than 10 APIs affected by missing or wrong permission checks,e specially for Delete APIs or common APIs where multiple headers are accepted.

williamlardier avatar Sep 21 '22 15:09 williamlardier

Hello williamlardier,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e avatar Sep 21 '22 15:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

  • @miniscruff

bert-e avatar Sep 27 '22 09:09 bert-e

History mismatch

Merge commit #763090bf70510c24c5640309d76a52b0cb368a57 on the integration branch w/7.70/improvement/CLDSRV-281-complete-missing-permission-checks is merging a branch which is neither the current branch improvement/CLDSRV-281-complete-missing-permission-checks nor the development branch development/7.70.

It is likely due to a rebase of the branch improvement/CLDSRV-281-complete-missing-permission-checks and the merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

bert-e avatar Sep 27 '22 10:09 bert-e

/reset

williamlardier avatar Sep 27 '22 10:09 williamlardier

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e avatar Sep 27 '22 10:09 bert-e

Conflict

A conflict has been raised during the creation of integration branch w/8.5/improvement/CLDSRV-281-complete-missing-permission-checks with contents from w/8.4/improvement/CLDSRV-281-complete-missing-permission-checks and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/improvement/CLDSRV-281-complete-missing-permission-checks origin/development/8.5
 $ git merge origin/w/8.4/improvement/CLDSRV-281-complete-missing-permission-checks
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/improvement/CLDSRV-281-complete-missing-permission-checks

bert-e avatar Sep 27 '22 10:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

  • @miniscruff

bert-e avatar Sep 27 '22 10:09 bert-e

History mismatch

Merge commit #2bad5b0084e59aaef31b02bf611c7429b0f7f44d on the integration branch w/7.70/improvement/CLDSRV-281-complete-missing-permission-checks is merging a branch which is neither the current branch improvement/CLDSRV-281-complete-missing-permission-checks nor the development branch development/7.70.

It is likely due to a rebase of the branch improvement/CLDSRV-281-complete-missing-permission-checks and the merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

bert-e avatar Sep 27 '22 11:09 bert-e

/reset

williamlardier avatar Sep 27 '22 11:09 williamlardier

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e avatar Sep 27 '22 11:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

  • @miniscruff

bert-e avatar Sep 27 '22 12:09 bert-e

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

bert-e avatar Sep 27 '22 17:09 bert-e

/approve

williamlardier avatar Sep 29 '22 09:09 williamlardier

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

  • :heavy_check_mark: development/7.10

  • :heavy_check_mark: development/7.70

  • :heavy_check_mark: development/8.4

  • :heavy_check_mark: development/8.5

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e avatar Sep 29 '22 09:09 bert-e

I have successfully merged the changeset of this pull request into targetted development branches:

  • :heavy_check_mark: development/7.10

  • :heavy_check_mark: development/7.70

  • :heavy_check_mark: development/8.4

  • :heavy_check_mark: development/8.5

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue CLDSRV-281.

Goodbye williamlardier.

bert-e avatar Sep 29 '22 09:09 bert-e