backbeat icon indicating copy to clipboard operation
backbeat copied to clipboard

remove GC producer from ObjectProcessor

Open benzekrimaha opened this issue 1 year ago • 3 comments

Issue : BB-554

benzekrimaha avatar Sep 25 '24 15:09 benzekrimaha

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval :star:
/bypass_build_status Bypass the build and test status :star:
/bypass_commit_size Bypass the check on the size of the changeset TBA :star:
/bypass_incompatible_branch Bypass the check on the source branch prefix :star:
/bypass_jira_check Bypass the Jira issue check :star:
/bypass_peer_approval Bypass the pull request peers' approval :star:
/bypass_leader_approval Bypass the pull request leaders' approval :star:
/approve Instruct Bert-E that the author has approved the pull request. :writing_hand:
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e avatar Sep 25 '24 15:09 bert-e

Incorrect fix version

The Fix Version/s in issue BB-554 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.0

Please check the Fix Version/s of BB-554, or the target branch of this pull request.

bert-e avatar Sep 25 '24 15:09 bert-e

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.67%. Comparing base (93d499f) to head (31d9ca6). Report is 2 commits behind head on development/8.7.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ecycle/objectProcessor/LifecycleObjectProcessor.js 73.07% <100.00%> (-2.79%) :arrow_down:
...ectProcessor/LifecycleObjectTransitionProcessor.js 50.74% <100.00%> (+19.49%) :arrow_up:

... and 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.14% <ø> (+0.01%) :arrow_up:
Ingestion 69.24% <ø> (ø)
Lifecycle 75.83% <100.00%> (+0.35%) :arrow_up:
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/8.7    #2545      +/-   ##
===================================================
+ Coverage            69.58%   69.67%   +0.08%     
===================================================
  Files                  194      194              
  Lines                12822    12819       -3     
===================================================
+ Hits                  8922     8931       +9     
+ Misses                3890     3878      -12     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.64% <0.00%> (+<0.01%) :arrow_up:
api:routes 9.53% <0.00%> (+<0.01%) :arrow_up:
bucket-scanner 85.76% <ø> (ø)
ingestion 12.48% <0.00%> (+<0.01%) :arrow_up:
lib 7.53% <0.00%> (+<0.01%) :arrow_up:
lifecycle 19.33% <12.50%> (-0.18%) :arrow_down:
notification 0.88% <0.00%> (+<0.01%) :arrow_up:
replication 18.92% <0.00%> (+<0.01%) :arrow_up:
unit 44.58% <100.00%> (+0.61%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 26 '24 16:09 codecov[bot]

/approve

benzekrimaha avatar Oct 15 '24 08:10 benzekrimaha

I have successfully merged the changeset of this pull request into targetted development branches:

  • :heavy_check_mark: development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue BB-554.

Goodbye benzekrimaha.

The following options are set: approve

bert-e avatar Oct 15 '24 10:10 bert-e