BB-598 Validate Kafka messages against all bucket notification rules

[nicolas2bert]

This PR addresses an issue in the bucket notification queue processor where consumed Kafka messages were only being validated against the first defined bucket notification rule (for a given destination queue: queueArn). So, notifications were not being sent out for objects/versions that matched the other defined rules.

Fix details:

• Updated the validation logic to ensure that each consumed Kafka message is validated against all defined bucket notification rules.
• Ensured that notifications are correctly sent out for objects/versions matching any of the rules with the correct matching rule id.

[bert-e]

Hello nicolas2bert,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	:star:
/bypass_build_status	Bypass the build and test status	:star:
/bypass_commit_size	Bypass the check on the size of the changeset TBA	:star:
/bypass_incompatible_branch	Bypass the check on the source branch prefix	:star:
/bypass_jira_check	Bypass the Jira issue check	:star:
/bypass_peer_approval	Bypass the pull request peers' approval	:star:
/bypass_leader_approval	Bypass the pull request leaders' approval	:star:
/approve	Instruct Bert-E that the author has approved the pull request.		:writing_hand:
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-598 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 7.70.14

• 8.5.5

• 8.6.47

• 8.7.0

Please check the Fix Version/s of BB-598, or the target branch of this pull request.

[nicolas2bert]

ping

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

[nicolas2bert]

/create_integration_branches

[bert-e]

Conflict

A conflict has been raised during the creation of integration branch w/8.5/bugfix/BB-598/notification with contents from bugfix/BB-598/notification and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/bugfix/BB-598/notification origin/development/8.5
 $ git merge origin/bugfix/BB-598/notification
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/bugfix/BB-598/notification

The following options are set: create_integration_branches

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/BB-598/notification into development/7.70
• w/8.5/bugfix/BB-598/notification will be merged into development/8.5
• w/8.6/bugfix/BB-598/notification will be merged into development/8.6
• w/8.7/bugfix/BB-598/notification will be merged into development/8.7

The following branches will NOT be impacted:

• development/7.10
• development/7.4

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following options are set: create_integration_branches

[nicolas2bert]

@bert-e approve

[bert-e]

I have successfully merged the changeset of this pull request into targetted development branches:

• :heavy_check_mark: development/7.70

• :heavy_check_mark: development/8.5

• :heavy_check_mark: development/8.6

• :heavy_check_mark: development/8.7

The following branches have NOT changed:

• development/7.10
• development/7.4

Please check the status of the associated issue BB-598.

Goodbye nicolas2bert.

The following options are set: approve, create_integration_branches