sbt-git icon indicating copy to clipboard operation
sbt-git copied to clipboard

Using a comparison that supports semver

Open arvkonstantin opened this issue 1 year ago • 3 comments

In cases where there are 2 or more tags on the same commit, and semver is also used, the previous version fell with an error, because it did a split point by point and cast everything to int. Semver is the most common option for forming a version name, so it would be better to use it.

arvkonstantin avatar Apr 03 '24 11:04 arvkonstantin

Sorry this PR got ignored for so long. In order for this to be mergeable, could you add at least one test showing the improved behavior...?

SethTisue avatar Sep 07 '24 08:09 SethTisue

The extra commits I added are from #249 — once that PR goes through, we can rebase this and drop those commits. I wanted to see if they would help with the CI failure.

SethTisue avatar Sep 07 '24 14:09 SethTisue

the CI failure seems to be real, so it appears this needs further work

SethTisue avatar Sep 07 '24 14:09 SethTisue