sourcebans-pp icon indicating copy to clipboard operation
sourcebans-pp copied to clipboard

change installation process instead of requiring navigating / deleting files yourself

Open Naleksuh opened this issue 5 years ago • 1 comments

Description

Motivation and Context

This change is not required, but makes installing much easier and less reliant on manual control. (To prevent malicious users from completing the installation, the config.php file will not be written automatically, which is a security issue on its own, but will be handled in a later PR).

How Has This Been Tested?

I have tested them through independent deleting of directories and Header Locations to point to the install folder. They were not used under SourceBans thus far, but is planned.

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING document.

Naleksuh avatar Apr 09 '20 18:04 Naleksuh

In addition, GitHub automatically changed the formatting codec of system-functions.php, so it will show as though the entire document has been deleted and readded. In reality, the only change there is adding the function to delete folders.

Naleksuh avatar Apr 09 '20 18:04 Naleksuh