sbi icon indicating copy to clipboard operation
sbi copied to clipboard

Adapt SNRE to new DensityEstimator abstraction

Open gmoss13 opened this issue 1 year ago • 4 comments

It would be good to create a RatioEstimator to use for SNRE methods, similar to DensityEstimator abstraction already implemented. The API and broadcasting should be similar, so possibly this should be handled in a parent Estimator class (see #966)

gmoss13 avatar Mar 13 '24 20:03 gmoss13

I will take a look at this and formulate some ideas.

bkmi avatar Mar 18 '24 15:03 bkmi

The purpose of the layer is to:

  1. compute the loss
  2. wrap the ratio estimate (for example for weighing it)
  3. embedding functions for both theta and x (subsuming StandardizeInputs #1036)
  4. provide a function to combine embed_theta(theta) and embed_x(x) into a single tensor.

Non-goals:

  • introduce methods to approximate ratios of normalized distributions as in torch-mist here

Progress:

  • [x] Change classifier_nn helper function to return new Ratio Estimator Class
  • [x] Integrate new interface into SNRE base classes.

bkmi avatar Mar 19 '24 13:03 bkmi

Note: this will address the ratio aspect of #957 .

bkmi avatar Mar 19 '24 14:03 bkmi

this is being updated to reflect the goals of #1041 and #1046

bkmi avatar Mar 20 '24 10:03 bkmi

solved with #1097

janfb avatar Jul 09 '24 16:07 janfb